Support multiple heater/cooler entities and valve ranges other than 0-100% #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this update is very interesting, should be merged even if I don't know if could generate some backward incompatibility |
ScratMan
added a commit
that referenced
this pull request
Apr 10, 2024
|
Thanks for the contribution. I cherry-picked some code to merge it with a simplification/cleanup I already prepared. Applied in v2024.4.0-beta1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple heater or cooler entity ids can be configured if for example you want to control a room with multiple radiators with smart TRVs. Similarly, a custom output range can be defined to support valves with control range other than 0-100%. For example, Eurotronic Spirit TRVs have a valve control range of 0-99 (really!).
I also updated README to reflect new functionality and to clarify some issues that confused me at first.