Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow the toggled love and favorite button colors to be changed with dark-www #4895

Closed
DNin01 opened this issue Jul 24, 2022 · 3 comments
Closed

Allow the toggled love and favorite button colors to be changed with dark-www #4895

DNin01 opened this issue Jul 24, 2022 · 3 comments
Labels
scope: addon Related to one or multiple addons type: enhancement New feature for the project

Comments

@DNin01
Copy link
Member

DNin01 commented Jul 24, 2022

Right now, they're always red and yellow respectively. This feature is mainly to allow color-blind users to accommodate the experience so that they can more easily tell if they have clicked something. You can already change the "text and icon highlight color" color in the Editor dark mode and customizable colors addon to change the appearance of the toggleable things in the editor, like the hide/show switch, but this doesn't cover the love and favorite buttons.

Just an idea.
@DNin01 DNin01 added status: needs triage Needs triaging by putting relevant labels type: enhancement New feature for the project labels Jul 24, 2022
@WorldLanguages WorldLanguages added scope: addon Related to one or multiple addons and removed status: needs triage Needs triaging by putting relevant labels labels Jul 25, 2022
@DNin01
Copy link
Member Author

DNin01 commented Jan 17, 2023

There's currently a PR on scratch-www to make these icons colorblind-friendly, so this problem should be resolved after that happens.

@DNin01 DNin01 closed this as completed Jan 17, 2023
@WorldLanguages
Copy link
Member

@DNin01 What's the PR number?

@DNin01
Copy link
Member Author

DNin01 commented Jan 17, 2023

@DNin01 What's the PR number?

scratchfoundation/scratch-www#7264

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
scope: addon Related to one or multiple addons type: enhancement New feature for the project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@WorldLanguages @DNin01