Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

block-cherry-picking doesn't account for cutting blocks #7023

Closed
OneShot-Niko opened this issue Dec 31, 2023 · 2 comments
Closed

block-cherry-picking doesn't account for cutting blocks #7023

OneShot-Niko opened this issue Dec 31, 2023 · 2 comments
Labels
scope: upstream Related to something we depend on (like Scratch, a library, or the browser) type: bug A bug in the addon loader, or in a specific addon

Comments

@OneShot-Niko
Copy link
Contributor

OneShot-Niko commented Dec 31, 2023

Description

I'm actually unsure if this is intentional or not but thought it'd probably be better if I made an issue anyways since there doesn't appear to be any

What should happen

cutting a block (with CTRL+X) will only account for that block rather than copying everything below it as well

What actually happens

Everything below the block gets copied as well so you are forced to delete the entire lane that you don't need

Steps to reproduce

  1. enable block-cherry-picking (if you haven't or had it disabled for some reason)
  2. (A) go into the editor or (B) one of your projects
    3a. Spam a few random blocks and include a C block presumably
  3. go to any line of code and hold CTRL, then cut the block.
  4. Paste, it won't only be the singular block you held CTRL with.

No idea how this could get fixed considering they both use CTRL, unless maybe this could be avoided by adding a shift variation that only focuses on the specific block?
Though, somewhat related: #6804

Demonstration(s) and additional context

No response.

Environment

Browser: Firefox 121.0 (32 bit)
Scratch Addons version: f23b744
Operating system: Windows 10

@OneShot-Niko OneShot-Niko added status: needs triage Needs triaging by putting relevant labels type: bug A bug in the addon loader, or in a specific addon labels Dec 31, 2023
@OneShot-Niko OneShot-Niko changed the title block-cherry-picking: cutting a block with CTRL held still includes the blocks below it block-cherry-picking doesn't account for cutting blocks Dec 31, 2023
@DNin01
Copy link
Member

DNin01 commented Jan 1, 2024

There is an upstream issue that I can replicate without using Scratch Addons, and might be what you're experiencing.

When cutting, only the focused block is removed, but when you paste cut or copied blocks, the entire stack starting from the block you cut or copied is pasted.

Block.cut.and.paste.discrepancy.mp4

At least this doesn't happen when using the editor-devtools addon's "Cut Block" button.

block-cherry-picking wasn't designed to fix or cause this bug, so I'm going to close this issue as an upstream bug.

About us implementing a bug fix in the form of an addon, I think it makes more sense for this bug fix to be a different addon.

@DNin01 DNin01 closed this as not planned Won't fix, can't repro, duplicate, stale Jan 1, 2024
@DNin01 DNin01 added scope: upstream Related to something we depend on (like Scratch, a library, or the browser) and removed status: needs triage Needs triaging by putting relevant labels labels Jan 1, 2024
@OneShot-Niko
Copy link
Contributor Author

There is an upstream issue that I can replicate without using Scratch Addons, and might be what you're experiencing.

When cutting, only the focused block is removed, but when you paste cut or copied blocks, the entire stack starting from the block you cut or copied is pasted.
Block.cut.and.paste.discrepancy.mp4

At least this doesn't happen when using the editor-devtools addon's "Cut Block" button.

block-cherry-picking wasn't designed to fix or cause this bug, so I'm going to close this issue as an upstream bug.

About us implementing a bug fix in the form of an addon, I think it makes more sense for this bug fix to be a different addon.

Fair.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: upstream Related to something we depend on (like Scratch, a library, or the browser) type: bug A bug in the addon loader, or in a specific addon
Projects
None yet
Development

No branches or pull requests

2 participants