Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include copyright notices in licenses.html #7498

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

DNin01
Copy link
Member

@DNin01 DNin01 commented Jun 4, 2024

Resolves #7494

Changes

  • Adds a copyright notice, including the year and full name fields, to each license that requires it, and updated license-info.json with that information.
  • Line breaks have been inserted in licenses without line breaks for hard word wrapping for consistency.

Reason for changes

The licenses of the libraries we use require giving attribution.

Notes

  • License text is sourced from the source code of the libraries for the versions that we use. License information may need to be revised if we update a dependency.
  • scratchblocks uses an MIT license, but the copyright notice is written a little differently, so I made a copy of the MIT license file just for it.
  • It looks to me like the Scratch Addons website has its own license info file, so we shouldn't need to make any changes to keep displaying library license information on our website.
  • Merging this may cause conflicts in Remove handle-licenses.js #7479 (and also the other way around), but I don't really mind. That's been sorted now - don't worry.

Tests

Tested.

@Hans5958
Copy link
Member

Hans5958 commented Jun 4, 2024

Keep in mind that there is the "Dependencies" section on the Credits page, which links what libraries that are used and its license identifier, which should be fine, especially for reference only.

@mxmou mxmou added the scope: webpages Related to the web pages (settings page, pop-up, etc) label Jun 7, 2024
"color-picker-web-component": {
"license": "MIT",
"year": "2020",
"fullname": "Wouter Vroege <wouter@woutervroege.nl>"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this library has been quite modified by me, not sure how licensing works. source is no longer available tho

@WorldLanguages
Copy link
Member

Okay, I merged the other one

@DNin01
Copy link
Member Author

DNin01 commented Jun 18, 2024

Alright, the conflicts have been resolved, and all the correct licenses seem to be displayed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: webpages Related to the web pages (settings page, pop-up, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Legal: Should the licenses page include the author and copyright year?
5 participants