Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addon popups should not be hardcoded #773

Closed
WorldLanguages opened this issue Nov 17, 2020 · 2 comments · Fixed by #1006
Closed

Addon popups should not be hardcoded #773

WorldLanguages opened this issue Nov 17, 2020 · 2 comments · Fixed by #1006
Labels
scope: addon.json About the addon.json file structure scope: webpages Related to the web pages (settings page, pop-up, etc) type: enhancement New feature for the project
Milestone
v1.7.0

Comments

@WorldLanguages
Copy link
Member

(Moved from #15 and #16)

Currently (since v1.0.0 until now) popups are "hardcoded". This means that:

  1. Addons can't specify details about their popup on their manifest
  2. Users can't remove/reorder/etc. popups
  3. Addons have no standard way to send messages from/to popups
  4. Addons don't actually have addon.* APIs, and localization works weirdly on them
@WorldLanguages WorldLanguages added the type: enhancement New feature for the project label Nov 17, 2020
@WorldLanguages WorldLanguages added this to the v1.5.0 milestone Nov 17, 2020
This was referenced Nov 17, 2020
Closed
Closed
@Hans5958
Copy link
Member

Hans5958 commented Dec 8, 2020

Any updates?

@WorldLanguages
Copy link
Member Author

@Hans5958 Likely dropping for next release, when I made this issue localization wasn't a thing, so I'll need to coordinate with apple :P

@TheColaber TheColaber mentioned this issue Dec 11, 2020
Merged
@WorldLanguages WorldLanguages modified the milestones: v1.5.0, v1.6.0 Dec 12, 2020
@WorldLanguages WorldLanguages modified the milestones: v1.6.0, v1.7.0 Dec 23, 2020
@WorldLanguages WorldLanguages mentioned this issue Jan 7, 2021
Closed
8 tasks
@mxmou mxmou added scope: addon.json About the addon.json file structure scope: webpages Related to the web pages (settings page, pop-up, etc) labels Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
scope: addon.json About the addon.json file structure scope: webpages Related to the web pages (settings page, pop-up, etc) type: enhancement New feature for the project
Projects
None yet
Milestone
v1.7.0
Development

Successfully merging a pull request may close this issue.

Non hardcoded popups & toggle addons through popup (responsive iframe) TheColaber/ScratchAddons
3 participants
@Hans5958 @WorldLanguages @mxmou