New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the design of various components #2
Conversation
Still not very accurate given that the API doesn't include deleted posts
…ove unneeded parameters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments but they aren't blocking - LGTM
Add missing s-radio, align to the right
Keep the margin -> padding change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried this with buttons and not moving the progress. "s-btn__xs" and padding seems do-able to me. No "s-btn__xs" even without padding is a bit too cramped up. This was supposed to be a comment on this commit, but I can't figure out how to do that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(deleted) Sorry about this, but I'm not allowed to delete a "Review changed" comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a test review comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can ditch the [...el.querySelectorAll("...")].forEach
and just do: el.querySelectorAll("...").forEach
as the method exists on the collection returned
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw, I suppose we can move the "pe-none"
class to config object
@@ -3239,10 +3239,8 @@ | |||
|
|||
radios.forEach((radio) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably optimize here:
radios.forEach(({ style }) => {
style.borderLeft = radioWithBorders ? `${radioSeperatorColour} solid ${radioSeperatorSize}px` : "none";
});
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably wrap the new Date().toISOString().replace("T", " ")
into a utility
GM_setValue
,GM_getValue
andGM_deleteValue
if the user uses a userscript manager, otherwise store config inlocalStorate
.async/await
syntax onfetch
es instead of.then()
/.catch()
.