Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(context tracking): add secondary sdk name and version #12

Merged
merged 3 commits into from
Jan 16, 2024

Conversation

samber
Copy link
Member

@samber samber commented Jan 15, 2024

No description provided.

@MD4 MD4 force-pushed the feat-context-library-sdk-name-and-version branch from cfa9e8d to 6b51325 Compare January 16, 2024 13:27
@@ -354,6 +354,8 @@ This is the Screeb tag options object.
| Name | Type | Description |
| :------ | :------ | :------ |
| `screebEndpoint?` | `string` | Please don't do this. |
| `sdkName?` | `string` | SDK name (eg: sdk-browser, sdk-react, sdk-angular, etc...) |
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pas sûr qu'on veuille laisser le dev remplir ce truc

WDYT ?

sauf s'il faisait lui-même un wrapper communautaire ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pas faux, pour le coup c'est généré mais je peux simplement le cacher dans la doc, as you wish !

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Au pire on peut le laisser c'est peut être pas si grave en vrai

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comme tu veux

@MD4 MD4 force-pushed the feat-context-library-sdk-name-and-version branch from 6b51325 to e76592b Compare January 16, 2024 14:05
@MD4 MD4 merged commit 9630eae into master Jan 16, 2024
1 check passed
@MD4 MD4 deleted the feat-context-library-sdk-name-and-version branch January 16, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants