fix(action): Set recommended environment variables #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rootless Docker installation script suggests setting XDG_RUNTIME_DIR to ~/.docker/run when it isn't already set. Doing so prevents flakiness caused by the fact that some runners set XDG_RUNTIME_DIR to /run/user/1001 but don't have ~/.docker/run, while some don't set it but do have ~/.docker/run. Also follow the script's suggestion of prepending ~/bin to the PATH. Disregard the suggestion to set DOCKER_HOST to unix://$XDG_RUNTIME_DIR/docker.sock since we already achieve the same effect by setting the context to rootless.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rootless Docker installation script suggests setting
XDG_RUNTIME_DIRto~/.docker/runwhen it isn't already set. Doing so prevents flakiness caused by the fact that some runners setXDG_RUNTIME_DIRto/run/user/1001but don't have~/.docker/run, while some don't set it but do have~/.docker/run. Also follow the script's suggestion of prepending~/binto thePATH. Disregard the suggestion to setDOCKER_HOSTtounix://$XDG_RUNTIME_DIR/docker.socksince we already achieve the same effect by setting the context to rootless.