fix(action): Stop rootful Docker daemon #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kurt-von-Laven
force-pushed
the
action
branch
8 times, most recently
from
8898158
to
6aa2d0c
Compare
Kurt-von-Laven
changed the title
GitHub Actions started managing the Docker daemon via systemd unannounced. That caused this action to fail when trying to start the rootless Docker daemon, because the rootful Docker daemon is already running. Stop the rootful Docker daemon before attempting to start the rootless Docker daemon. When Docker is managed via systemd, there is no need to run dockerd-rootless.sh separately since the rootless Docker install script starts the rootless Docker daemon automatically.
Kurt-von-Laven
changed the title
mwarres
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Actions started managing the Docker daemon via systemd unannounced. That caused this action to fail when trying to start the rootless Docker daemon, because the rootful Docker daemon is already running. Stop the rootful Docker daemon before attempting to start the rootless Docker daemon. When Docker is managed via systemd, there is no need to run
dockerd-rootless.shseparately since the rootless Docker install script starts the rootless Docker daemon automatically.