Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tlog-play receives input from recording #147

Open
spbnick opened this issue Dec 5, 2017 · 2 comments
Open

Tlog-play receives input from recording #147

spbnick opened this issue Dec 5, 2017 · 2 comments
Labels
bug pri: high
Milestone
Production-Ready

Comments

@spbnick
Copy link
Member

spbnick commented Dec 5, 2017

Apparently some recorded sessions can include control characters prompting the playback terminal to emulate input, which can then be interpreted by tlog-play as playback controls pausing or quitting the playback and potentially doing anything. An example could be a vim editing session.

I wasn't able to quickly find out how that happens exactly and how to deal with that, but we need to find it out and fix this. Perhaps check other playback programs for solutions.
@spbnick spbnick added this to the v4 milestone Dec 5, 2017
@spbnick
Copy link
Member Author

spbnick commented Dec 5, 2017

OK, no, what's likely is the recording asking the terminal for reports, and the playback terminal dutifully replying.

@spbnick
Copy link
Member Author

spbnick commented Dec 5, 2017

It doesn't seem like we can stop the terminal from replying to the control sequences and we can't read the control keys from anywhere but the terminal. We should either filter out the request control sequences from the output or the response control sequences from the input, whichever is easier and more reliable.

The most reliable way, however, might be embedding a terminal emulator as #91 describes.

@spbnick spbnick mentioned this issue Dec 6, 2017
Open
spbnick added a commit to spbnick/tlog that referenced this issue Dec 19, 2017
@spbnick
Filter out some input control sequences on playback
7699e73 
Attempt to filter out some common control sequences coming from the
terminal in response to control sequences from recordings, on playback.

This alleviates Scribery#147, but it would require embedding a terminal emulator
to properly fix it.
spbnick added a commit to spbnick/tlog that referenced this issue Dec 19, 2017
@spbnick
Filter out some input control sequences on playback
2bbc4ac 
Attempt to filter out some common control sequences coming from the
terminal in response to control sequences from recordings, on playback.

This alleviates Scribery#147, but it would require embedding a terminal emulator
to properly fix it.
spbnick added a commit to spbnick/tlog that referenced this issue Dec 19, 2017
@spbnick
Filter out some input control sequences on playback
2ecb77a 
Attempt to filter out some common control sequences coming from the
terminal in response to control sequences from recordings, on playback.

This alleviates Scribery#147, but it would require embedding a terminal emulator
to properly fix it.
@spbnick spbnick modified the milestones: v4, Production-Ready Dec 19, 2017
spbnick added a commit to spbnick/tlog that referenced this issue Jan 27, 2018
@spbnick
Filter out some more input control sequences
caa7551 
Concerns Scribery#147.
spbnick added a commit to spbnick/tlog that referenced this issue Jan 27, 2018
@spbnick
Filter out some more input control sequences
77ef70d 
Concerns Scribery#147.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug pri: high
Projects
None yet
Milestone
Production-Ready
Development

No branches or pull requests
1 participant
@spbnick