tlitest tlog_rec fix journal_find_last failures #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justin-stephenson
requested changes
May 29, 2019
spoore1
force-pushed
the
journal_fix
branch
2 times, most recently
from
d6477a2
to
a63b6d2
Compare
justin-stephenson
force-pushed
the
journal_fix
branch
from
a63b6d2
to
8b2f644
Compare
journal_find_last was using _COMM only to match journal entries. This can fail to find some entries if they do not include that field. The workaround here is to add an additional check for SYSLOG_IDENTIFIER if _COMM is not found.
justin-stephenson
force-pushed
the
journal_fix
branch
from
8b2f644
to
f3937b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
journal_find_last was using _COMM only to match journal entries. This
can fail to find some entries if they do not include that field. The
workaround here is to add an additional check for SYSLOG_IDENTIFIER if
_COMM is not found.