Add tlog-play "output" option #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would say this is a bit too involved and expands the interface unnecessarily. Simply detect if stdout is a terminal or not (e.g. by checking errno after the failed |
Allow users to send tlog-play output to a file with -o by redirecting stdout to a file.
justin-stephenson
force-pushed
the
play_output_to_file
branch
from
534238e
to
e81de15
Compare
justin-stephenson
force-pushed
the
play_output_to_file
branch
from
e81de15
to
87ed8c0
Compare
spoore1
reviewed
Jun 25, 2019
| with open(outputfile) as f: | ||
| read_data = f.read() | ||
| assert recordedtext in read_data | ||
| f.closed |
There was a problem hiding this comment.
Would misc.check_outfile() be better here? or don't want/need that here specifically?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow redirecting
tlog-playoutput to a file with a new-o/--outputoptionThis is in reference to #219
@spbnick @spoore1 Would you mind a quick review?