ES Reader: Handle missing fields when reading from ES #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justin-stephenson
force-pushed
the
es_play_handle_missing_fields
branch
2 times, most recently
from
5182bc2
to
c9a1f82
Compare
spbnick
reviewed
Aug 7, 2019
There was a problem hiding this comment.
This is a good start, but it has a few problems. First of all users are likely to be surprised and confused if only the ES backend handled the missing fields. Instead we need to change the schema, and documentation to describe the optional fields, what they would default to, and change the json_msg.c to handle it.
Another side is the choice of the optional fields. I think the "host" and "user" can't normally be empty strings and so they'll not be omitted in ES. Instead we need to handle "in_txt" and "out_txt" being absent.
Allow playing back recordings when in_txt/out_txt fields are missing. An empty string "" value will be used as a default if these fields are absent. This handles missing fields when reading from ElasticSearch or other backends.
justin-stephenson
force-pushed
the
es_play_handle_missing_fields
branch
from
c9a1f82
to
11419dc
Compare
|
Thank you Nikolai, I made those changes. The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When playing back from elasticsearch, add empty placeholder value for
fields
(in_txt, host, user)if these fields are missing in ES database.