Support non-TTY stdin/stdout and fix a bunch of issues along the way #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't call poll(2) in TTY source if all the FDs in the FD list are inactive, as in this case poll(2) won't be able to return any events and would wait indefinitely with negative timeout.
Write invalid initial character bytes with their own timestamps, instead of the last character timestamps in tlog_json_stream_write.
Ignore attempts to move the time back in tlog_json_chunk_advance to allow characters which are terminated late to be written. Move the time succession assertion to tlog_json_chunk_write.
Don't rollback the whole character if tlog_json_stream_write was invoked with an already started character and the complete character didn't fit. Otherwise the rollback loses data and can even underflow the input buffer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.