Sort les méthodes liées au call à l'API GitHub dans un service séparé #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…extract-github-api-calls * 'principale' of github.com:Scribouilli/scribouilli: Add unit tests (#111)
Ynote
commented
Nov 15, 2023
Ynote
commented
Nov 15, 2023
DavidBruant
approved these changes
Nov 15, 2023
DavidBruant
reviewed
Nov 17, 2023
Merged
DavidBruant
approved these changes
Nov 27, 2023
| import './../types.js' | ||
|
|
||
| /** | ||
| * @overlaod |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Avec l'intention d'ajouter la connexion et la communication avec GitLab, cette PR prépare le terrain en essayant d'extraire tous les appels qu'on fait à l'API GitHub dans un service séparé.
J'ai repris la logique de
databaseAPIoù on exporte un singleton. L'idée, c'est que ce service soit instancié au chargement de la page en fonction de chez qui on s'est déjà connecté avec les informations qu'on a danslocalStorage. Dans le cas où il n'y a pas d'info, on est redirigé sur la page de connexion.Il me reste encore à tester entièrement l'application pour vérifier que je n'ai pas cassé de fonctionnalité avec ce refacto. Mais sur les happy path (création de site, ajout de page), ça fonctionne déjà bien.