-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow localized product details #375
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code wise good. But I'm not sure about the general approach anymore (see slack discussion).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (8fec5e0)
Good stuff 🚀!
cartAddedMessage: { | ||
title: 'Confirmation message after adding', | ||
}, | ||
cartAddLabel: { | ||
title: 'Add-button label', | ||
}, | ||
cartRemovedMessage: { | ||
title: 'Confirmation message after removing', | ||
}, | ||
cartRemoveLabel: { | ||
title: 'Remove-button label', | ||
}, | ||
cartUnvailableMessage: { | ||
title: 'Add-button tooltip if not logged in', | ||
description: | ||
'The placeholder __product__ is available for all labels and messages.', | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide a working copy where you cleared these values.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final implementation with hardcoded de/en localizers. No working copy needed.