New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored UnifiNetworkState to include UniFi devices #136
Open
cdellasanta
wants to merge
12
commits into
Scrounger:master
Choose a base branch
from
cdellasanta:feature/unifi-network-example-v3
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Refactored UnifiNetworkState to include UniFi devices #136
cdellasanta
wants to merge
12
commits into
Scrounger:master
from
cdellasanta:feature/unifi-network-example-v3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cdellasanta
commented
Dec 30, 2020
•
edited
edited
- Refactored script from Javascript to TypeScript
- Adaptions and use of own global functions for better state handling
- Added UniFi devices to listings
- Updated views for theme usage (vis-materialdseign 0.4.x)
- Update lists after each run of the unifi adapter (instead of scheduler)
…itial UnifiNetworkState example as posted by Scrounger in ioBroker forum
… own global functions for state handling, added UniFi devices to listings, updated views for theme usage (vis-materialdseign 0.4.x)
Thanks a lot for this PR. I will do a review in the next few days |
If you merge, can you please squash the changes to a single commit? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.