Add more descriptive error for merkle verification errors

Se7en-Seas · Apr 4, 2024 · d7a883f · d7a883f
1 parent 224613e
commit d7a883f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/base/Roles/ManagerWithMerkleVerification.sol b/src/base/Roles/ManagerWithMerkleVerification.sol
@@ -55,7 +55,7 @@ contract ManagerWithMerkleVerification is Auth {
     error ManagerWithMerkleVerification__FlashLoanNotExecuted();
     error ManagerWithMerkleVerification__FlashLoanNotInProgress();
     error ManagerWithMerkleVerification__BadFlashLoanIntentHash();
-    error ManagerWithMerkleVerification__FailedToVerifyManageProof();
+    error ManagerWithMerkleVerification__FailedToVerifyManageProof(address target, bytes targetData, uint256 value);
     error ManagerWithMerkleVerification__Paused();
 
     //============================== EVENTS ===============================
@@ -240,7 +240,7 @@ contract ManagerWithMerkleVerification is Auth {
                 packedArgumentAddresses
             )
         ) {
-            revert ManagerWithMerkleVerification__FailedToVerifyManageProof();
+            revert ManagerWithMerkleVerification__FailedToVerifyManageProof(target, targetData, value);
         }
     }
 

diff --git a/test/ManagerWithMerkleVerification.t.sol b/test/ManagerWithMerkleVerification.t.sol
@@ -1524,7 +1524,10 @@ contract ManagerWithMerkleVerificationTest is Test, MainnetAddresses {
 
         vm.expectRevert(
             abi.encodeWithSelector(
-                ManagerWithMerkleVerification.ManagerWithMerkleVerification__FailedToVerifyManageProof.selector
+                ManagerWithMerkleVerification.ManagerWithMerkleVerification__FailedToVerifyManageProof.selector,
+                targets[0],
+                targetData[0],
+                values[0]
             )
         );
         manager.manageVaultWithMerkleVerification(manageProofs, decodersAndSanitizers, targets, targetData, values);