Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added sla-dashboard as custom entity #8

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rosogon
Copy link
Contributor

@rosogon rosogon commented May 12, 2015

@andreaturli : Could you take a look at it?

I'm mixing the installation process with the launch process, but I don't know how to do it better.

./manage.py runserver $SOCKET &
echo $! > $PID_FILE
env:
SLA_MANAGER_URL: $brooklyn:formatString("http://%s:%s", component("sla-core").attributeWhenReady("host.address"), component("sla-core").attributeWhenReady("http.port"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are you waiting for this URL if you are not using it?
maybe better to use something like
launch.latch: $brooklyn:component("sla-core").attributeWhenReady("service.isUp")

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What url? SLA_MANAGER_URL? I do use it. But sth strange happens, because brooklyn tries to reassign it each minute.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you mean SLA_MANAGER_URL is expected by your python app, even if not passed explicitly to manage.py runserver?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SLA_MANAGER_URL points to slacore endpoint, and has a default value of http://localhost:8080/sla-service (suitable for developing purposes), and overridable with an env var (https://github.com/SeaCloudsEU/sla-dashboard/blob/d06337aea0684a0773f1b3397304b8246188d977/sladashboard/settings.py#L97).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants