Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jekyll blog post future dates don't seem to be functioning #170

Open
altsalt opened this issue Mar 12, 2020 · 9 comments
Open

Jekyll blog post future dates don't seem to be functioning #170

altsalt opened this issue Mar 12, 2020 · 9 comments

Comments

@altsalt
Copy link
Member

@altsalt altsalt commented Mar 12, 2020

Looks like #169 went live despite being future dated. Isn't a big deal, but might be nice to fix for queuing when we get closer to the event.

@nhandler

This comment has been minimized.

Copy link
Contributor

@nhandler nhandler commented Mar 12, 2020

Running the site in Docker did not exhibit this issue. Is it possible this is due to some datetime issue on the actual seagl.org site rather than in the code?

@kormoc

This comment has been minimized.

Copy link
Contributor

@kormoc kormoc commented Mar 12, 2020

Jekyll is a static site generator. It runs after every commit and the results are published to the site. The dates on the posts are really for sorting, not for holding on to until a specific date. There's no system in place to re-run the Jekyll build process to publish pending posts automatically.

@nhandler

This comment has been minimized.

Copy link
Contributor

@nhandler nhandler commented Mar 12, 2020

So wouldn't the expected behavior be that the future doesn't get included when jekyll runs since we haven't hit that date? That is what happens when running with Docker.

This also feels like a change/regression. There is a large note in the README from @vmbrasseur (21ea91d) specifically calling out the ability to use future dating to schedule posts. If this no longer works, we should remove the note at the very least. However, ideally, we would be able to support this workflow (potentially using GitHub Actions, which also support running on a schedule).

@kormoc

This comment has been minimized.

Copy link
Contributor

@kormoc kormoc commented Mar 12, 2020

I don't know exactly the command line GitHub renders Jekyll with, but there is a argument you can pass in called --future that will render future pages.

https://jekyllrb.com/docs/configuration/options/

When you are calling it via docker, it's not set in our config file or being set in the command line, so it's not rendering then. I can only assume that GitHub has this enabled by default. We could open a ticket with them to see if they know why this changed or why it's happening.

@AndrewKvalheim

This comment has been minimized.

Copy link
Contributor

@AndrewKvalheim AndrewKvalheim commented Mar 12, 2020

Odd. I don't see anything about that in the GitHub Pages documentation, but at least one other person has noticed a discrepancy:

However, your future posts will be shown in GitHub Pages. I couldn’t check the detail but it seemed the default Jekyll setting is different between a local and GitHub Pages. So, please don’t forget to set false to hide future posts correctly.

future: false
AndrewKvalheim added a commit that referenced this issue Mar 12, 2020
@AndrewKvalheim

This comment has been minimized.

Copy link
Contributor

@AndrewKvalheim AndrewKvalheim commented Mar 12, 2020

Seems to have worked.

@nhandler

This comment has been minimized.

Copy link
Contributor

@nhandler nhandler commented Mar 17, 2020

This still seems to be broken. The post has yet to appear. I'm not sure if we need to force some other change to the site to cause it to be regenerated/redeployed or if something else is broken.

@nhandler nhandler reopened this Mar 17, 2020
@meonkeys

This comment has been minimized.

Copy link
Member

@meonkeys meonkeys commented Mar 18, 2020

I just pushed an unrelated commit ( ab89c61 ). That forced a site rebuild/deploy and now the videos post shows up.

Also: https://stackoverflow.com/questions/24098792/how-to-force-github-pages-build/24099328#24099328

@nhandler

This comment has been minimized.

Copy link
Contributor

@nhandler nhandler commented Mar 18, 2020

Cool. I'll update the docs about scheduling posts for future publication to call this out. I still wonder though if we could utilize something like GitHub Actions and have them force a daily rebuild to facilitate truly automated scheduled posts again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.