Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why the generated SeaORM entity files are in expanded format? #28

Closed
billy1624 opened this issue Aug 4, 2022 · 1 comment · Fixed by #36
Closed

Why the generated SeaORM entity files are in expanded format? #28

billy1624 opened this issue Aug 4, 2022 · 1 comment · Fixed by #36

Comments

@billy1624
Copy link
Member

billy1624 commented Aug 4, 2022

The expanded generator produce all Rust code. Its easier to modify, but harder to maintain long term. In case a new version of the generator exists you have to regenerate the whole project and apply the your custom modifications again.

I saw the line above from the docs, SeaQL/seaql.github.io#41.

I agree we should generate the async-graphql types in expanded format. However, for SeaORM entity, compact format should be the default (of cause we should make it configurable: generating compact / expanded format).

@karatakis
Copy link
Collaborator

When I will start working on proc macro library I will create a compact format generator. Then I will use it as default and give option to use expanded format if needed.

@karatakis karatakis mentioned this issue Aug 8, 2022
17 tasks
@karatakis karatakis mentioned this issue Aug 29, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants