Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly declare font color in qtextbrowser #150

Merged
merged 4 commits into from
Mar 14, 2024

Conversation

Ferelith-maker
Copy link
Contributor

What type of Pull Request is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Describe your changes in brief

Explicitly declare font color in the Qtextbrowser window. The background of the window does not change to dark mode, however if the font color is not declared, qt will automatically select the font to light colors on a light background

Checklist

  • Tested locally
  • Added new dependencies
  • Updated documentation
  • Added tests

Related Issues

  • Related Issue #
  • Closes #

@Ferelith-maker Ferelith-maker changed the title Explicitely declare font color in qtextbrowser Explicitly declare font color in qtextbrowser Mar 13, 2024
Copy link
Contributor

@jfantinhardesty jfantinhardesty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!

@Ferelith-maker Ferelith-maker merged commit 020e046 into main Mar 14, 2024
12 of 13 checks passed
@Ferelith-maker Ferelith-maker deleted the fix-gui-about-page-in-dark-theme branch March 14, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants