This repository has been archived by the owner on Feb 8, 2024. It is now read-only.
CORTX-34189 Fix status-cortx-cloud.sh regression (data-only deploy) #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a regression that was introduced with multi-pod cortx-control pods. Signed-off-by: Walter Lopatka <walter.lopatka@seagate.com>
Signed-off-by: Walter Lopatka <walter.lopatka@seagate.com>
Signed-off-by: Walter Lopatka <walter.lopatka@seagate.com>
keithpine
approved these changes
Sep 9, 2022
| @@ -115,6 +115,7 @@ fi | |||
|
|
|||
| # Check pods | |||
| expected_count=$(helm get values cortx --all --namespace "${namespace}" --output yaml | yq .control.replicaCount) | |||
| [[ ${data_deployment} == true ]] && expected_count=0 | |||
There was a problem hiding this comment.
Another approach would be to check the.control.enabled value, but I suppose solution.yaml should take precedence for the scripts.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With v0.10.0 and the introduction of potentially multiple replicas of cortx-control pods, I introduced a regression in status-cortx-cloud.sh, such that the script reported failures with a data-only deployment. This is because logic was added to account for potentially multiple replicas did not take into account a possible data-only deployment.
Along with the fix I have added a basic regression test that deploys with data-only deployment.
Type of change
Applicable issues
CORTX image version requirements
N/A
How was this tested?
Added new regression test that deploys with data-only deployment.
I also ran the existing regression test to confirm that standard deployment works as expected.
Checklist
If this change requires newer CORTX or third party image versions:
imagefields in solution.example.yaml have been updated to use the required versions.appVersionfield of the Helm chart has been updated to use the new CORTX version.If this change addresses a CORTX Jira issue:
CORTX-XXXXX:)