fix(testing): improve sanity requirements error handling

test/.env-example

@@ -0,0 +1,3 @@
+DOTHILL_USERNAME=
+DOTHILL_PASSWORD=
+DOTHILL_API_ADDR=

test/sanity

@@ -1,25 +1,31 @@
 #! /usr/bin/env bash
 
+set -e
+
+function teardown {
+	rm -vf ${secretsFile} /tmp/{controller,node}.sock
+}
+
+trap teardown EXIT
+
 secretsFileTmpl="secrets.template.yml"
 secretsFile="secrets.yml"
 inititatorNameFile="/etc/iscsi/initiatorname.iscsi"
 
 function setup {
 	cd $(dirname $0)
+	set -a; . .env; set +a
 	envsubst < ${secretsFileTmpl} > ${secretsFile}
-	cat ${inititatorNameFile} > /dev/null
-	if [ $? -ne 0 ]; then
-		echo "InitiatorName=iqn.2020-01.io.enix:sanity-test-cluster" > ${inititatorNameFile}
+	if [ ! -f ${inititatorNameFile} ]; then
+		>&2 echo "/etc/iscsi/initiatorname.iscsi is missing, please run the following commands"
+		>&2 echo -e "  sudo mkdir -p /etc/iscsi"
+		>&2 echo -e "  sudo sh -c 'echo \"InitiatorName=iqn.2020-01.io.enix:sanity-test-cluster\" > ${inititatorNameFile}'"
+		exit 1
 	fi
 }
 
-function teardown {
-	rm ${secretsFile}
-}
-
 setup
 go test ../cmd/controller $@
 out=$?
-teardown
 
 exit ${out}