Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Port device rediscovery check into FC node #72

Merged
merged 2 commits into from
Mar 29, 2023
Merged

fix: Port device rediscovery check into FC node #72

merged 2 commits into from
Mar 29, 2023

Conversation

David-T-White
Copy link
Collaborator

device rediscovery prevention code was added for the SAS nodes. Port this code into the FC node as well.

jskazinski
jskazinski approved these changes Mar 29, 2023
View reviewed changes
Copy link
Member

@jskazinski jskazinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but requesting we start converting log messages to structured logging.

pkg/storage/fcNode.go Outdated Show resolved Hide resolved
pkg/storage/fcNode.go Outdated Show resolved Hide resolved
seagate-chris
seagate-chris approved these changes Mar 29, 2023
View reviewed changes
Copy link
Collaborator

@seagate-chris seagate-chris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@David-T-White David-T-White merged commit f0ece2a into Seagate:main Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seagate-chris seagate-chris seagate-chris approved these changes

@jskazinski jskazinski jskazinski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@David-T-White @seagate-chris @jskazinski