refactor: New node gRPC server for initiator retrieval #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original version of this driver used the nodes iQN as nodeID, and passed FC and SAS initiators through the topology map. This change adds a new gRPC server to each node, and changes the Node ID to be the node IP address.
Add protocol buffer generation as part of the Makefile for the node gRPC service
Remove hyphens from environment variable names and add names into the configuration constants of the common driver code
jskazinski
reviewed
Apr 19, 2023
|
Overall, looks good David. |
seagate-chris
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original version of this driver used the nodes iQN as nodeID, and passed FC and SAS initiators through the topology map. This change adds a new gRPC server to each node, and changes the Node ID to be the node IP address.
This PR also removes the initial topology support that came with the use of the topology feature to communicate initiator information.