-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run two tabs at a time with threading #16
Conversation
|
||
if __name__ == '__main__': | ||
t1 = threading.Thread(target=main) | ||
t2 = threading.Thread(target=main) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great implementation. One thing to note: python's threading module will not allow you to run both of threads simulataneously. Sadly, only multiprocessing and futures support this. You can read about this here. https://docs.python.org/3/library/threading.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality provided by threading is better implemented in #21. This should not be pulled. However, this is functional code and a great way to learn the basics of threading.
#21 Is now closed due to being incredibly behind on pulls. I will create a new pull requests implementing this some time later today |
This approach is deprecated and further discussion should be brought to #39 |
@BigweldIndustries @pws1453 thanks for the feedback! Checking out #39 for learning and inspiration. Appreciate being a part of this <3 |
I'm newish to python. I want to basically make this so you can pass in args for how many tabs or bowsers you want running at a time.
IE:
would run 5 tabs or browsers at a time