Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the changelog file #20

Merged
merged 2 commits into from
Oct 13, 2020
Merged

Add the changelog file #20

merged 2 commits into from
Oct 13, 2020

Conversation

arturparkhisenko
Copy link
Contributor

@arturparkhisenko arturparkhisenko commented Oct 13, 2020 •
edited
Loading

Changelog:

And as a part of the Hacktoberfest month, I would appreciate and like to ask you to add all the necessary labels(tags), please.
It is hacktoberfest topic to the repository and hacktoberfest-accepted if PR was accepted.

@SeanMcP
Copy link
Owner

SeanMcP commented Oct 13, 2020

@arturparkhisenko This looks good! Did you use a tool to generate this file or is it based on commit messages?

This does a better job of tracking changes than I could have done!

@arturparkhisenko
Copy link
Contributor Author

@SeanMcP I did it manually, what I found is working best for me, if the repo has tags, I would use a URL like this v1.1...v1.1.2
You can get this URL by clicking the Compare button when you're looking at the releases page.

@arturparkhisenko
Copy link
Contributor Author

@SeanMcP I believe there are some tools to automate it if we'll be able to follow some format, there's a lot of them.

@SeanMcP SeanMcP self-requested a review October 13, 2020 12:33
@SeanMcP SeanMcP self-assigned this Oct 13, 2020
SeanMcP
SeanMcP requested changes Oct 13, 2020
View reviewed changes
Copy link
Owner

@SeanMcP SeanMcP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like I mentioned above, this is great work. Two small requests for change:

CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@SeanMcP SeanMcP assigned arturparkhisenko and unassigned SeanMcP Oct 13, 2020
@SeanMcP SeanMcP added this to In progress in v1.1.3 Oct 13, 2020
@SeanMcP SeanMcP self-requested a review October 13, 2020 17:18
SeanMcP
SeanMcP approved these changes Oct 13, 2020
View reviewed changes
Copy link
Owner

@SeanMcP SeanMcP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for making those changes 👍

@SeanMcP SeanMcP assigned SeanMcP and unassigned arturparkhisenko Oct 13, 2020
@SeanMcP SeanMcP merged commit 54ff8b0 into SeanMcP:master Oct 13, 2020
v1.1.3 automation moved this from In progress to Done Oct 13, 2020
@arturparkhisenko
Copy link
Contributor Author

@SeanMcP Can you also add the hacktoberfest-accepted tag? Thanks

@SeanMcP SeanMcP added the hacktoberfest-accepted A valid PR for Hacktoberfest label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeanMcP SeanMcP SeanMcP approved these changes

Assignees

@SeanMcP SeanMcP

Labels
hacktoberfest-accepted A valid PR for Hacktoberfest
Projects
No open projects
v1.1.3
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a changelog
2 participants
@arturparkhisenko @SeanMcP