Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Row Convolution in PyTorch #46

Closed
SeanNaren opened this issue May 4, 2017 · 18 comments
Closed

Implement Row Convolution in PyTorch #46

SeanNaren opened this issue May 4, 2017 · 18 comments
Assignees

Comments

@SeanNaren
Copy link
Owner

This will give us the ability to do a real time model, being able to predict just using forward only RNNs.

@SeanNaren SeanNaren self-assigned this May 4, 2017
@EgorLakomkin
Copy link
Contributor

I wanted to work on this if you do not mind?

@SeanNaren
Copy link
Owner Author

Go for it @EgorLakomkin! Let me know if you run into issues etc

@ryanleary
Copy link
Collaborator

@EgorLakomkin you may find this helpful: PaddlePaddle/Paddle#2373

@ryanleary
Copy link
Collaborator

Make any headway here @EgorLakomkin?

@EgorLakomkin
Copy link
Contributor

Thx for the links @ryanleary ! I will push the vanilla implementation this week

@dlmacedo
Copy link

What is a row convolution?

@willfrey
Copy link

@ryanleary
Copy link
Collaborator

@EgorLakomkin did you have any luck with this?

@dimatter
Copy link

bump!?

1 similar comment
@dlmacedo
Copy link

bump!?

@jinserk
Copy link
Contributor

jinserk commented Sep 8, 2017

Did you see this? Is it different from the DS2's row conv layer?
https://discuss.pytorch.org/t/how-to-use-temporalrowconvolution/4283

@SeanNaren
Copy link
Owner Author

It is! Thanks @jinserk that will be super useful.

@EgorLakomkin
Copy link
Contributor

Sorry for late reply, recently been very busy. I am experimenting with convolutional-only acoustic models (like wav2letter) and I was thinking if it would be interesting to include them in this repo though it is not related to deepspeech?

@EgorLakomkin
Copy link
Contributor

EgorLakomkin commented Oct 12, 2017

Bump! I implemented wav2letter-like architecture recently and it works quite good, but faster than rnn-based models. Do you think it could be a good addition to this repo?

@SeanNaren
Copy link
Owner Author

Make it a branch? I'll more than happily take it as a new branch :)

@ryanleary
Copy link
Collaborator

It would be cool to eventually support different model types within this repo if the model loading/options etc can be handled in a robust way. There is a lot of boilerplate code here that would be necessary for any speech system, so certainly good to reuse it.

@dlmacedo
Copy link

dlmacedo commented Oct 13, 2017 via email

@SeanNaren
Copy link
Owner Author

Added in #180

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants