Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test BPRemoteWebDriverTestCase>>#testCookies fails in Squeak #32

Open
Rinzwind opened this issue Jun 26, 2019 · 5 comments
Open

Test BPRemoteWebDriverTestCase>>#testCookies fails in Squeak #32

Rinzwind opened this issue Jun 26, 2019 · 5 comments

Comments

@Rinzwind
Copy link
Member

Rinzwind commented Jun 26, 2019

The test BPRemoteWebDriverTestCase>>#testCookies fails in Squeak:

https://travis-ci.org/SeasideSt/Parasol/jobs/550887953#L1139

@Rinzwind
Copy link
Member Author

This is due to an error in generating a response; WAWebServerAdaptor>>#responseFrom: sends #oldNetscapeString to a WACookie, which is not implemented:

500 Internal Server Error 2019-06-26 20-23-51

Rinzwind pushed a commit that referenced this issue Jun 26, 2019
@Rinzwind
Copy link
Member Author

Related to: SeasideSt/Seaside@a9b5b35#diff-9f7d0e1bf4044ba665796ec6d551dcbc

For now, I simply marked the test as an expected failure on Squeak (953555d).

Rinzwind pushed a commit that referenced this issue Jun 26, 2019
… failures for Squeak; added a Smalltalk-CI 'postLoading' script to load a patch for WACookie>>#oldNetscapeString on Squeak instead (see: #32).
@Rinzwind
Copy link
Member Author

Instead of marking the test as an expected failure, I included a post-loading script to add an implementation of WACookie>>#oldNetscapeString (e024e6f).

@jbrichau
Copy link
Member

@Rinzwind That looks more like a bug in Seaside to me, because older Pharo versions have older Zinc loaded. I quickly added the issue so we can fix it there (SeasideSt/Seaside#1141)

@timrowledge
Copy link

Forgive me if this seems a stupid question - I just hit this bug in my testing of seaside 3.5.4 in Squeak 6.1 trunk.
It's not at all clear to me from looking at the issues here what the 'proper' fix is. It works as best I can tell with a simple substitution of rfc6265String for oldNetscapeString in WAWebServerAdaptor>>#responseFrom:.
The relevant package seems to be WebClient-Seaside-Adaptor.
WAWebServerAdaptor.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants