Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple value Headers only set the latest one when converting a WAResponse to ZnResponse #1211

Closed
eMaringolo opened this issue Jul 10, 2020 · 0 comments · Fixed by #1212
Closed

Multiple value Headers only set the latest one when converting a WAResponse to ZnResponse #1211

eMaringolo opened this issue Jul 10, 2020 · 0 comments · Fixed by #1212

Comments

@eMaringolo
Copy link
Contributor

In ZnZincServerAdaptor>>#responseFrom: the header conversion from WAHeaderFields to ZnHeaders if a header appears several times in aWAHeaderFields only the last one in the iteration is added to ZnResponse headers.

"<snip>"
partialHeaders	keysAndValuesDo: [ :key :value | fullHeaders at: key put: value greaseString ].

It does at:put and it should do at:add: instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes to multiple value headers convertion #1211 eMaringolo/Seaside
1 participant
@eMaringolo