Fix WAVersionUploader #1334
Merged
Fix WAVersionUploader #1334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marschall
commented
Aug 23, 2022
| @@ -1,10 +1,10 @@ | |||
| actions | |||
| newVersion: aWorkingCopy | |||
| | version stream | | |||
| version := [ aWorkingCopy newVersion ] | |||
| version := [ aWorkingCopy newVersionIn: aWorkingCopy repositoryGroup ] | |||
There was a problem hiding this comment.
I'm not sure whether or #repositoryGroup or #theCachedRepository or something else is correct.
There was a problem hiding this comment.
I have not investigated further, but seems like this is also how it's done in MetacelloPharoPlatform and the MCWorkingCopyTest. So looks fine to me.
I have never really understood the use of the tool though...
marschall
added
the
CampSmalltalk 2022
jbrichau
approved these changes
Sep 1, 2022
| @@ -1,10 +1,10 @@ | |||
| actions | |||
| newVersion: aWorkingCopy | |||
| | version stream | | |||
| version := [ aWorkingCopy newVersion ] | |||
| version := [ aWorkingCopy newVersionIn: aWorkingCopy repositoryGroup ] | |||
There was a problem hiding this comment.
I have not investigated further, but seems like this is also how it's done in MetacelloPharoPlatform and the MCWorkingCopyTest. So looks fine to me.
I have never really understood the use of the tool though...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the version uploader on Pharo 10.
RWBinaryOrTextStreamwas undeclared#newVersionwas not implemented