Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JQAutocomplete (follow-up to issue #1232): content-type for json call… #1364

Merged
merged 1 commit into from
Jun 4, 2023

Conversation

jbrichau
Copy link
Member

@jbrichau jbrichau commented Jun 4, 2023

…back in jQueryUI autocompleter should be application/json and not text/plain. Reworked the callback implementation to no longer create intermediate objects for serialization to json but use the json canvas directly.

…back in jQueryUI autocompleter should be application/json and not text/plain. Reworked the callback implementation to no longer create intermediate objects for serialization to json but use the json canvas directly.
@codecov
Copy link

codecov bot commented Jun 4, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.03 ⚠️

Comparison is base (9866f65) 54.13% compared to head (3d53ed6) 54.11%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1364      +/-   ##
==========================================
- Coverage   54.13%   54.11%   -0.03%     
==========================================
  Files        8870     8871       +1     
  Lines       72018    72049      +31     
==========================================
  Hits        38989    38989              
- Misses      33029    33060      +31     
Impacted Files Coverage Δ
...eFunctionalTest.class/instance/renderContentOn..st 0.00% <0.00%> (ø)
...est.class/instance/renderSelectedPackageNameOn..st 0.00% <0.00%> (ø)
.../JQAutocomplete.class/instance/search.callback..st 0.00% <0.00%> (ø)
...complete.class/instance/search.labels.callback..st 0.00% <0.00%> (ø)
...e/JQAutocomplete.class/instance/sourceCallback..st 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jbrichau jbrichau merged commit fc295e5 into master Jun 4, 2023
14 of 22 checks passed
@jbrichau jbrichau deleted the fix-autocomplete branch June 4, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant