Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turbo hotwired #1365

Merged
merged 34 commits into from
Sep 17, 2023
Merged

Turbo hotwired #1365

merged 34 commits into from
Sep 17, 2023

Conversation

jbrichau
Copy link
Member

@jbrichau jbrichau commented Jun 6, 2023

This (currently draft) PR is an ongoing effort to implement https://hotwired.dev/ support for Seaside.

@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Patch coverage: 11.68% and project coverage change: -5.52% ⚠️

Comparison is base (c928889) 54.19% compared to head (b9587b4) 48.67%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1365      +/-   ##
==========================================
- Coverage   54.19%   48.67%   -5.52%     
==========================================
  Files        8887     8946      +59     
  Lines       72220    80490    +8270     
==========================================
+ Hits        39139    39178      +39     
- Misses      33081    41312    +8231     
Files Changed Coverage Δ
...ckage/WARenderer.extension/instance/javascript..st 0.00% <0.00%> (ø)
...kage/WAPluggablePresenter.class/instance/block..st 0.00% <0.00%> (ø)
...ggablePresenter.class/instance/renderContentOn..st 0.00% <0.00%> (ø)
...ackage/WAExamplesLibrary.class/instance/todoCss.st 0.00% <0.00%> (ø)
...Examples.package/WATodo.class/instance/addTodo..st 0.00% <0.00%> (ø)
...Examples.package/WATodo.class/instance/children.st 0.00% <0.00%> (ø)
...amples.package/WATodo.class/instance/initialize.st 0.00% <0.00%> (ø)
...ckage/WATodo.class/instance/renderAddNewTodoOn..st 0.00% <0.00%> (ø)
....package/WATodo.class/instance/renderContentOn..st 0.00% <0.00%> (ø)
...es.package/WATodo.class/instance/renderTodosOn..st 0.00% <0.00%> (ø)
... and 68 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…final callback that is executed. Also make it available as the default action on a form.
…t such that you do not need to care about the id
…n combination with a redirect to a WATurboRenderingContinuation
@jbrichau jbrichau marked this pull request as ready for review September 17, 2023 10:58
@jbrichau jbrichau merged commit b2d5425 into master Sep 17, 2023
18 of 26 checks passed
@jbrichau jbrichau deleted the turbo branch September 17, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant