Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #1369 (improvements for WAGettextExporter) #1370

Merged
merged 4 commits into from
Jul 17, 2023

Conversation

jbrichau
Copy link
Member

@jbrichau jbrichau commented Jul 17, 2023

Tackles issues mentioned in #1369

@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Patch coverage: 94.03% and no project coverage change.

Comparison is base (ec8c4a2) 54.14% compared to head (b642301) 54.15%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1370   +/-   ##
=======================================
  Coverage   54.14%   54.15%           
=======================================
  Files        8876     8883    +7     
  Lines       72097    72141   +44     
=======================================
+ Hits        39037    39067   +30     
- Misses      33060    33074   +14     
Impacted Files Coverage Δ
...etTextExporter.class/class/newForRBEnvironment..st 0.00% <0.00%> (ø)
...mentsFinder.class/instance/translatedArguments..st 0.00% <0.00%> (-100.00%) ⬇️
...tExporter.class/instance/createAndSortTriplets..st 100.00% <100.00%> (ø)
.../WAGetTextExporter.class/instance/createHeaders.st 100.00% <100.00%> (ø)
...class/instance/createStringMethodRefDictionary..st 100.00% <100.00%> (ø)
...tTextExporter.class/instance/currentDateAndTime.st 100.00% <100.00%> (ø)
.../WAGetTextExporter.class/instance/exportCatalog.st 100.00% <100.00%> (ø)
...e/WAGetTextExporter.class/instance/exportHeader.st 100.00% <100.00%> (ø)
...orter.class/instance/exportHeaderLineKey.value..st 100.00% <100.00%> (ø)
.../WAGetTextExporter.class/instance/formatString..st 100.00% <100.00%> (ø)
... and 10 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jbrichau jbrichau changed the title Fix for issue #1369 Fix for issue #1369 (improvements for WAGettextExporter) Jul 17, 2023
@jbrichau jbrichau merged commit 22d3f96 into master Jul 17, 2023
16 of 22 checks passed
@jbrichau jbrichau deleted the 1369-WAGettextExporter-catalog-generation-issues branch July 17, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant