Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slime renovation #1398

Merged
merged 10 commits into from Jan 27, 2024
Merged

Slime renovation #1398

merged 10 commits into from Jan 27, 2024

Conversation

jbrichau
Copy link
Member

Ported the Seaside Slime rules to the Renraku code critiques framework.
Removed obsolete rules (i.e. those with transforms for porting from Seaside 2.8)

Copy link

codecov bot commented Jan 14, 2024

Codecov Report

Attention: 116 lines in your changes are missing coverage. Please review.

Comparison is base (cb9f147) 48.75% compared to head (8192f79) 48.34%.

Files Patch % Lines
...kage/WASlime.class/class/findAttributeSelectors.st 0.00% 25 Missing ⚠️
...elopment.class/class/enableSeasideCodeCritiques.st 0.00% 16 Missing ⚠️
...package/WASlime.class/class/isCallbackSelector..st 0.00% 7 Missing ⚠️
...allSuperImplementationRule.class/instance/group.st 0.00% 4 Missing ⚠️
...gesStateWhileRenderingRule.class/instance/group.st 0.00% 4 Missing ⚠️
...age/WACookieConversionRule.class/instance/group.st 0.00% 4 Missing ⚠️
...ltiplePrimaryAjaxCallbacks.class/instance/group.st 0.00% 4 Missing ⚠️
...DoNotUseWhileRenderingRule.class/instance/group.st 0.00% 4 Missing ⚠️
...DoNotUseWithinCallbackRule.class/instance/group.st 0.00% 4 Missing ⚠️
...ctCallbackCodeToMethodRule.class/instance/group.st 0.00% 4 Missing ⚠️
... and 10 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1398      +/-   ##
==========================================
- Coverage   48.75%   48.34%   -0.41%     
==========================================
  Files        9071     9157      +86     
  Lines       81579    82113     +534     
==========================================
- Hits        39771    39701      -70     
- Misses      41808    42412     +604     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jbrichau jbrichau merged commit ffcd2b3 into master Jan 27, 2024
17 of 26 checks passed
@jbrichau jbrichau deleted the slime-renovation branch January 27, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant