Fix for issue #89(Improve `savestate` error handling) #92

XuefengHuang · 2015-04-20T12:53:37Z

I fix savestate error message issue and create a unit test for this PR, this is test result:

Xuefengs-MacBook-Pro:runnable Xuefeng$ python utf.py -f ut_seash_savestate_nicermessage.py 
Testing module: seash
Now starting subprocess: ut_seash_subprocess.py
Generating user keys...
Generating owner key...
Writing config file...
Writing vessel dictionary...
Now running setup script: ut_seash_setup.py
    Running: ut_seash_setup.py                                  [ PASS ]
    Running: ut_seash_savestate_nicermessage.py                 [ PASS ]
Now stopping subprocess: ut_seash_subprocess.py
Removing: v1
Removing: v10
Removing: v2
Removing: v3
Removing: v4
Removing: v5
Removing: v6
Removing: v7
Removing: v8
Removing: v9

Add better error messages for two problems. One is using savestate before having loaded at least a pubkey, and work as that identity. Another is using savestate to a write-protected file.

aaaaalbert · 2015-04-20T12:56:15Z

tests/ut_seash_savestate_nicermessage.py

+#pragma out Don't use savestate to a write-protected file.
+
+open('write_protected_file', 'w+').close()
+os.system('chmod a-w write_protected_file')


This won't work cross-platform (think Windows).

This unit test is to test error messages when using savestate before having loaded at least a pubkey, and work as that identity.

This unit test is to test error messages when using savestate to a write-protected file.

asm582 · 2015-05-15T21:48:01Z

I have tested this pull request and this can be merged.

Testing by running unit test:

cib@cib-VirtualBox:/seash/RUNNABLE$ python utf.py -f ut_seash_savestate_nicermessageone.py
Testing module: seash
Running: ut_seash_savestate_nicermessageone.py [ PASS ]
cib@cib-VirtualBox:/seash/RUNNABLE$ python utf.py -f ut_seash_savestate_nicermessagetwo.py
Testing module: seash
Running: ut_seash_savestate_nicermessagetwo.py [ PASS ]

Testing by manually entering command on seash:
cib@cib-VirtualBox:~/seash/RUNNABLE$ python seash.py

You can press the Tab key to enable tab complete when typing commands.

Enabled modules: factoids, geoip, modules, uploaddir, variables

!> savestate NO_KEYS_LOADED
Specify the key name by first typing 'as [username]'.
!> loadkeys guest0
as guest0
!> as guest0
guest0@ !> savestate write_protected_file
Permission denied: write_protected_file
guest0@ !> exit

XuefengHuang added 2 commits April 16, 2015 15:41

Improve savestate error handling.

00fc172

Add better error messages for two problems. One is using savestate before having loaded at least a pubkey, and work as that identity. Another is using savestate to a write-protected file.

Added a unit test for savestate's error messages

a5e4d7f

aaaaalbert reviewed Apr 20, 2015
View reviewed changes

XuefengHuang added 6 commits April 20, 2015 21:25

Added an unit test for savestate command

7112869

This unit test is to test error messages when using savestate before having loaded at least a pubkey, and work as that identity.

Added an unit test for savestate command

41857af

This unit test is to test error messages when using savestate to a write-protected file.

Split this unit test into two unit tests

1ca6cc6

Change another way to raise error message

fcb0243

Modify error message

507c1b4

Modify error message

4827887

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix for issue #89(Improve `savestate` error handling) #92

Fix for issue #89(Improve `savestate` error handling) #92

XuefengHuang commented Apr 20, 2015

aaaaalbert Apr 20, 2015

asm582 commented May 15, 2015

Fix for issue #89(Improve savestate error handling) #92

Are you sure you want to change the base?

Fix for issue #89(Improve savestate error handling) #92

Conversation

XuefengHuang commented Apr 20, 2015

aaaaalbert Apr 20, 2015

Choose a reason for hiding this comment

asm582 commented May 15, 2015

Fix for issue #89(Improve `savestate` error handling) #92

Fix for issue #89(Improve `savestate` error handling) #92