-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: Support integer64
in vgcd()
#318
Comments
Thanks, I will look into this next week, but at first sight this does not appear to be a code issue. integer64 is stored as double in R, the GCD C code for doubles is
so accuracy is up to 6 digits and you got this error because the GCD was too small. Perhaps use as.double() on the sequence and see what the CGD might be. |
Thanks. Using int <- seq(bit64::as.integer64(1), 10)
collapse::vgcd(as.double(int))
#> [1] 1 Created on 2022-09-03 with reprex v2.0.2 |
I've tried to code something specific for integer64, but I haven't really been able to figgure out how the values of the object behave, or how they are represented in C. When you call |
I would like to use the dtts package with data.table for time series. It uses nanotime which internally uses
bit64::integer64
. I would like to usevgcd()
to calculate the interval of the time series and fill in gaps. Currently, fast stats functions seem to work well withinteger64
, butvgcd()
did not. Could you consider adding support forvgcd()
forbit64::integer64
? Thanks!Created on 2022-09-03 with reprex v2.0.2
The text was updated successfully, but these errors were encountered: