Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the titlebar #209

Merged
merged 1 commit into from
Sep 25, 2022
Merged

Fix the titlebar #209

merged 1 commit into from
Sep 25, 2022

Conversation

Xaliks
Copy link
Contributor

@Xaliks Xaliks commented Sep 25, 2022

Fixes #203

remote has been removed from the electron.

I used ipcRenderer

Error

Uncaught TypeError: Cannot read properties of undefined (reading 'getCurrentWindow')
    at HTMLDivElement.<anonymous> (titlebar.js:20:25)

@Xaliks
Copy link
Contributor Author

Xaliks commented Sep 25, 2022

2022-09-25.22-27-39.mp4

@SebOuellette
Copy link
Owner

Looks good, thank you!

@SebOuellette SebOuellette merged commit bfb8599 into SebOuellette:master Sep 25, 2022
@Xaliks Xaliks deleted the fix-titlebar branch September 26, 2022 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SebOuellette SebOuellette SebOuellette approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot close/minimise/maximise application
2 participants
@Xaliks @SebOuellette