Change CDN URL for Twemoji #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebOuellette
approved these changes
Apr 19, 2023
|
Sorry this took so long.. Yeah sure this sounds like a good idea :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since there is now working alternative URL to load Twemoji script, this pull request changes CDN URL again, which was changed once before in f56858b, to load latest version of it with
@twemoji/apinpm package through jsDelivr.Following MaxCDN shutdown, one of former Twitter employee stated in twitter/twemoji#580 that they ended up creating and maintaining new fork since there can be legal consequences probably because they are no longer employed due to their boss who cannot even write basic HTML, and they will maintain said fork instead of Twitter's repository. Because of that, this pull request uses npm package associated with their fork, jdecked/twemoji, instead of Twitter's package.