fix(GoogleMapsAPIWrapper): run Google Maps Apis outside of Angular #1714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrap all Google Maps APIs calls in the wrapper with runOutsideAngular Fixes NgZone stability (issue sebholstein#815)
Codecov Report
@@ Coverage Diff @@
## master #1714 +/- ##
==========================================
- Coverage 50.45% 49.86% -0.59%
==========================================
Files 43 43
Lines 1881 1903 +22
Branches 170 170
==========================================
Hits 949 949
- Misses 928 950 +22
Partials 4 4
Continue to review full report at Codecov.
|
ghost
reviewed
Sep 17, 2019
ghost
added
the
|
@doom777 any news on this? Can I help you somehow? |
|
@doom777 Would really like to see this as well. I'm adding multiple maps to a page, and there is a performance bottleneck from all the logic being ran inside Angular's zone, which causes change detection to be ran very frequently while the maps are being built. |
|
@doom777 @mpienkowski Hi, any update on this? If this PR won't go through, can I make another? I'd love to see this change. |
ghost
approved these changes
Nov 5, 2019
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrap all Google Maps APIs calls in the wrapper with runOutsideAngular
Fixes NgZone stability (issue #815)