-
Notifications
You must be signed in to change notification settings - Fork 817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration with testability API #815
Comments
@rcomblen thanks for the report. This is really hard to debug. I'm skeptical that a |
@SebastianM I cannot promise I'll find the time for that :-( |
Having the same issue, but with angular 6 and using Protractor. Protractor times out because it is waiting for all the async tasks to finish which for google maps don't finish causing it to time out and break my e2e tests |
In my instance, there is a |
Same issue here. Have to bump up the timeout to 40 seconds for the |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Hey, has there been any progress into this? |
Wrap all Google Maps APIs calls in the wrapper with runOutsideAngular Fixes NgZone stability (issue sebholstein#815)
Issue description
I'm doing end-to-end testing of my app (that uses angular2-google-maps).
I'm resorting to the testability API of Angular, to wait for angular to be stable before doing my actions (just like protractor does), i.e. I wait for
to return true.
It seems angular2-google-maps often leaves pending tasks in the zone (hard to debug, as there is no API to inspect the pending tasks, see angular/angular#8219). Hence it is never stable, and my tests are blocked.
It would be nice to make sure there are no pending tasks in the zone, e.g. make sure
setTimeout
is wrapped in a_zone.runOutsideAngular
call when necessary.I guess the same applies to all the calls in the wrapper to the Google API. Logic by the Google code should run outside of the zone.
angular2 & angular2-google-maps version
1.6.0 (but I guess it happens just the same with newer versions).
The text was updated successfully, but these errors were encountered: