Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: TS Rewrite #66

Merged
merged 14 commits into from Oct 31, 2022
Merged

FEATURE: TS Rewrite #66

merged 14 commits into from Oct 31, 2022

Conversation

Sebobo
Copy link
Owner

@Sebobo Sebobo commented Oct 21, 2022

@Sebobo Sebobo added the enhancement New feature or request label Oct 21, 2022
@Sebobo Sebobo self-assigned this Oct 21, 2022
Also replaces ReactCSS usage with CSS modules
The previous array made it hard to override the global colors via custom settings

Resolves: #53
F.e. this can be used to set a CSS class instead of a color value

Resolves: #6
@Sebobo Sebobo marked this pull request as ready for review October 24, 2022 11:22
@Sebobo
Copy link
Owner Author

Sebobo commented Oct 24, 2022

@jonnitto would love to have you as reviewer of this PR 🙂

@jonnitto
Copy link
Contributor

The preset mode doesn't seem to work correctly:

presethex:
      type: string
      ui:
        label: 'Preset mode with hex values'
        inspector:
          editor: 'Shel.Neos.ColorPicker/ColorPickerEditor'
          editorOptions:
            mode: preset
            presetColors:
              - '#ff0000'
              - '#00ff00'
            allowEmpty: true
CleanShot.2022-10-27.at.17.02.43.mp4

@jonnitto
Copy link
Contributor

Also, the preset mode with non-hex values doesn't work correctly:

preset:
      type: string
      ui:
        label: 'Preset mode with objects'
        inspector:
          editor: 'Shel.Neos.ColorPicker/ColorPickerEditor'
          editorOptions:
            mode: preset
            presetColors:
              - color: rgb(var(--color-main-theme))
                label: 'Main'
                value: 'main'
              - color: green
                label: 'Grün'
                value: 'minor'
              - color: '#ff0000'
                label: 'Rot'
                value: red
            allowEmpty: true

@jonnitto
Copy link
Contributor

The hsla field show the fields with rgba values, but in this mode, I would expect the hsla values
CleanShot 2022-10-27 at 17 05 39@2x

@jonnitto
Copy link
Contributor

With alpha hidden, you could make the height of the color bar higher:

CleanShot 2022-10-27 at 17 06 59@2x

@jonnitto
Copy link
Contributor

The color bar is missing the drag handle:

CleanShot 2022-10-27 at 17 07 50@2x

@Sebobo
Copy link
Owner Author

Sebobo commented Oct 28, 2022

Thx for testing everything !!!

The preset mode doesn't seem to work correctly:

  • Fixed (only affected string only presets)

Also, the preset mode with non-hex values doesn't work correctly:

⚠️ This is currently not supported due to the used color plugin. I adjusted the readme to show this limitation. But of course one can set any color value in the value field.

With alpha hidden, you could make the height of the color bar higher:

  • Adjusted the styles

The color bar is missing the drag handle:

  • Fixed

The hsla field show the fields with rgba values, but in this mode, I would expect the hsla values

  • The fields component needs to be adapted for that

@Sebobo Sebobo merged commit 9ef3b04 into master Oct 31, 2022
@Sebobo Sebobo deleted the feature/ts-rewrite branch October 31, 2022 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants