Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove depreciated constants #539

Merged
merged 5 commits into from
Feb 1, 2024

Conversation

brg468
Copy link
Collaborator

@brg468 brg468 commented Jan 18, 2024

Use new enums in place of depreciated constants.

Should correct errors reported here: #537 and #536.

Might be worth making this a beta release. Although it seems like the changes are straightforward, I only have lights so the climate and alarm changes are untested.

@brg468 brg468 force-pushed the address-errors-in-constants branch from a679c1c to d5033b6 Compare January 18, 2024 20:43
Copy link
Collaborator

@JoeSchubert JoeSchubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to test, but I don't see any reason this should cause issues as long as the enums are correct/tested.

@Krispkiwi
Copy link

Is there a way to update with these changes yet?

@brg468
Copy link
Collaborator Author

brg468 commented Jan 30, 2024

Is there a way to update with these changes yet?

Download from my branch and replace your wyzeapi folder in custom_components with mine.

@JoeSchubert
Copy link
Collaborator

I could merge them, but I honestly don't handle the build process. That would really be a question for @SecKatie

@glyndon
Copy link

glyndon commented Jan 30, 2024

Is there a way to update with these changes yet?

Download from my branch and replace your wyzeapi folder in custom_components with mine.

Seems to be working fine here (HA: core, latest), but all I have are cams.

@brg468
Copy link
Collaborator Author

brg468 commented Jan 30, 2024

I realized I was getting warnings for climate and alarm, which I don’t have either. So I think everything should be good.

Copy link
Owner

@SecKatie SecKatie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you for providing this fix!

@SecKatie SecKatie merged commit ad9c13c into SecKatie:master Feb 1, 2024
4 checks passed
@brg468 brg468 deleted the address-errors-in-constants branch February 10, 2024 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants