-
-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove depreciated constants #539
Conversation
a679c1c
to
d5033b6
Compare
…68/ha-wyzeapi into address-errors-in-constants
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unable to test, but I don't see any reason this should cause issues as long as the enums are correct/tested.
Is there a way to update with these changes yet? |
Download from my branch and replace your wyzeapi folder in custom_components with mine. |
I could merge them, but I honestly don't handle the build process. That would really be a question for @SecKatie |
Seems to be working fine here (HA: core, latest), but all I have are cams. |
I realized I was getting warnings for climate and alarm, which I don’t have either. So I think everything should be good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thank you for providing this fix!
Use new enums in place of depreciated constants.
Should correct errors reported here: #537 and #536.
Might be worth making this a beta release. Although it seems like the changes are straightforward, I only have lights so the climate and alarm changes are untested.