Partially revert HMS error check #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SecKatie
approved these changes
May 27, 2024
|
It wasn’t the original reporter but another user with the issue reported it to be working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for SecKatie/ha-wyzeapi#591
The change was discussed here, and since neither Joe or I have the HMS, I was basing the change off of the fact that
_get_plan_binding_list_by_useris called once at startup, and the response there is'message': 'Success'and the typical 2001 code on invalid auth, so the error checker wouldn't function correctly. But apparently_monitoring_profile_activemust return a different response than everything else. This is untested of course but is the same response we were checking before.#83 (comment)