Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deduplicate BindGroups in wgpu renderer #97

Open
LPGhatguy opened this issue Jun 22, 2023 · 0 comments · May be fixed by #130
Open

Deduplicate BindGroups in wgpu renderer #97

LPGhatguy opened this issue Jun 22, 2023 · 0 comments · May be fixed by #130
Labels
cleanup

Comments

@LPGhatguy
Copy link
Member

Currently, we make a new BindGroup for every batch of vertices we draw. We should instead only create a new BindGroup for each unique set of textures!

In MS80, this would cut down the number of bind groups by... 600 per frame when the editor is open.
@Uriopass Uriopass linked a pull request Dec 20, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add bindgroup cache in wgpu Uriopass/yakui
1 participant
@LPGhatguy