Ccache to Kirbi conversion issue, missing hostname part in sname

[ShutdownRepo]

Configuration

impacket version: Impacket v0.9.25.dev1+20220208.122405.769c3196
Python version: Python 3.9.10

Issue

When obtaining a service ticket with getST, converting the .ccache ticket to .kirbi, and then doing .kirbi to .ccache results in a ticket missing a part in sname's hostname.

The issue also happens without the -impersonate flag.

I have located the error to be on the Ccache to Kirbi conversion.

Additional context

Issue raised there: #1260 (comment)

[wqreytuk]

I don't think this is a problem, it has no negative impact on the use of tickets

[ShutdownRepo]

It clearly has a negative impact, and you were the one who demonstrated it.

[wqreytuk]

It clearly has a negative impact, and you were the one who demonstrated it.

you mean can not be imported directly?

[wqreytuk]

and you have solved this problem by modifying ticketConverter.py?

[wqreytuk]

if you mean this, then it is not ticketConvert.py's fault, my ticket after converted can be imported and used even the description of it is not correct

[ShutdownRepo]

@wqreytuk worked together on the issues we faced with the service substitution and ticket conversion.

The issues are now fixed (#1202 (comment)). The initial issue with the conversion from Ccache to Kirbi can be fixed with #1265

The other issue with incomplete service substitution was fixed in commits of two separate pending PRs: 8953d05 and f71c3bb

[0xdeaddood]

Fixed. Thanks @ShutdownRepo and @wqreytuk!

[wqreytuk]

Thanks

glad to make some contributions