Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CCache refactor #1276

Merged
merged 21 commits into from Mar 11, 2022
Merged

CCache refactor #1276

merged 21 commits into from Mar 11, 2022

Conversation

0xdeaddood
Copy link
Collaborator

This PR includes:

  • Added new parseFile function to ccache.py + removed duplicate code related to loadfile function (#1166). This also addresses #1226.
  • Added support for CCache version 3 (#1106).
  • Modified fromKRBCRED function used to load a Kirbi file (#1254). It fixes #1056.
  • Added missing hostname part in sname in CCache to Kirbi conversion (#1265). It fixes #1264.
  • Added some unit tests.

reznok and others added 21 commits June 28, 2021 19:58
@reznok
Add support for V3 ccache
b8c8f9c
@reznok
Update KeyBlock name
de0bfa4
@rmaksimov
add the parseFile class method and remove all the duplicate code
1409b45
@rmaksimov
clean up the code
435dadf
@rmaksimov
remove incompatible changes with python2
d61c9ef
@rmaksimov
remove duplicate code in rbcd.py
921cc05
@0xdeaddood
CCache: Modified fromKRBCRED function used to load a Kirbi file
ce1017a 
- Added authtime field
- Changed keyvalue type
- It should fix #1056
@martingalloar
CCache: Added some unit tests
1c9624c 
- Parsing v3 and v4 ccache files to check #1106 (and not support for v1 and v2)
- Parsing creds from kirbi to check #1254
- Checking #1166 parseFile function
@ShutdownRepo
Fixing Ccache to Kirbi conversion leaving service hostname out
805a0a9
@rmaksimov
add the FileNotFoundError exception
2cb6ec7
@rmaksimov
fix the error message in the loadFile function
382e7c0
@rmaksimov
set the domain parameter as optional in the parseFile function, add t…
ec8e97f 
…he corresponding docstring
@rmaksimov
add missing TGT value
453cec8
@0xdeaddood
Merge branch 'reznok/master' into ccache-refactor
e844037
@0xdeaddood
CCache: Minor changes
5f39724 
- Added NotImplementedError for CCache v1 and v2
- Added backward compatibility
@0xdeaddood
Merge branch 'remove-duplicate-code' into ccache-refactor
5393619
@0xdeaddood
Updated copyright year
165361a
@0xdeaddood
Merge branch 'master' into ccache-refactor
834557a
@0xdeaddood
Merge branch 'ccache-to-kirbi' into ccache-refactor
2e9b8e3
@0xdeaddood
Merge branch 'ccache-tests' into ccache-refactor
8251464
@0xdeaddood
CCache: Fixed unit tests on 2.7 so no errrors are thrown
6e288da 
Co-authored-by: Martin Gallo <mgallo@secureauth.com>
@martingalloar
Copy link
Contributor

LGTM 🚀

@0xdeaddood 0xdeaddood merged commit 1271d36 into master Mar 11, 2022
@0xdeaddood 0xdeaddood deleted the ccache-refactor branch March 11, 2022 15:16
@rmaksimov rmaksimov mentioned this pull request May 24, 2022
Closed
@rmaksimov rmaksimov mentioned this pull request Sep 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@0xdeaddood @martingalloar @reznok @rmaksimov @ShutdownRepo