Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show correct end date for early execution #156

Merged
merged 2 commits into from
Jul 10, 2023
Merged

fix: show correct end date for early execution #156

merged 2 commits into from
Jul 10, 2023

Conversation

ThijnK
Copy link
Contributor

@ThijnK ThijnK commented Jun 30, 2023

Type of change

Bug fix

Does it contain breaking changes?

No

Description

Fixed a bug where a proposal that was executed early would say something like 'Ended x days ago', where x was based on the endDate instead of the executionDate. It will now correctly use the executionDate to show how long ago the proposal was executed.

Changes

  • Use the executionDate instead of endDate in the header of the proposal page for proposals that are executed early
  • Clarify a comment that explained this kind of situation in the proposal history component

@vercel
Copy link

vercel bot commented Jun 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dao-webapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 30, 2023 0:46am

@SecureSECO-DAO
Copy link
Contributor

SecureSECO-DAO commented Jul 10, 2023

This pull request has been merged by the SecureSECO DAO.

@SecureSECO-DAO SecureSECO-DAO merged commit 3b9013a into master Jul 10, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants