Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ethers instead of viem #19

Merged
merged 1 commit into from
Jun 22, 2023
Merged

Use ethers instead of viem #19

merged 1 commit into from
Jun 22, 2023

Conversation

mik-0
Copy link
Contributor

@mik-0 mik-0 commented Jun 22, 2023

Viem caused memory leak

Copy link
Contributor

@djeelun djeelun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@djeelun djeelun merged commit 74cee19 into dev Jun 22, 2023
1 check passed
@djeelun djeelun deleted the ethers-rework branch June 22, 2023 10:02
@jxom
Copy link

jxom commented Jun 22, 2023

What version of Node are you running? Node 18 and below has known memory issues when using fetch with signals (which viem uses). If you upgrade to the latest stable Node (20+), you shouldn’t be seeing the memory leak anymore.

wevm/viem#583 (comment)

@mik-0
Copy link
Contributor Author

mik-0 commented Jun 22, 2023

What version of Node are you running? Node 18 and below has known memory issues when using fetch with signals (which viem uses). If you upgrade to the latest stable Node (20+), you shouldn’t be seeing the memory leak anymore.

wagmi-dev/viem#583 (comment)

Oh, I see 👀 We are indeed running the project on node 18, we will take a look at upgrading node. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants